Fix Redpanda Migrator bundle output #3428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
mihaitodor-fix-redpanda-migrator-bundle-output
branch
2 times, most recently
from
ad791f7 to
21fb30c
Compare
rockwotj
approved these changes
Jun 3, 2025
Signed-off-by: Mihai Todor <mihai.todor@contractor.redpanda.com>
The output needs to know what custom label was set for the redpanda_migrator_bundle input, if any. Otherwise, it can't find the input components it needs to talk to. Signed-off-by: Mihai Todor <mihai.todor@contractor.redpanda.com>
mihaitodor
force-pushed
the
mihaitodor-fix-redpanda-migrator-bundle-output
branch
from
21fb30c to
85f6af7
Compare
Signed-off-by: Mihai Todor <mihai.todor@contractor.redpanda.com>
Signed-off-by: Mihai Todor <mihai.todor@contractor.redpanda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit annoying because the
redpanda_migratoroutput needs to query the input for topic configs. When using custom labels, we don't have any clever ways to tell what is the input label. I could attach aninput_labelmetadata field to each message, but that feels overkill. Introducing thisinput_bundle_labelfield feels a bit annoying and hard to discover, but maybe it's enough for now.